Add context and mounted check to _handleControllerChanged #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses a potential issue in the _handleControllerChanged function by adding a check for widget mounted status. The modification ensures that the animation is only triggered when the widget is still part of the widget tree, preventing errors that may arise when attempting to manipulate the animation on an unmounted widget.
alex-melnyk
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses a potential issue in the _handleControllerChanged function by adding a check for widget mounted status. The modification ensures that the animation is only triggered when the widget is still part of the widget tree, preventing errors that may arise when attempting to manipulate the animation on an unmounted widget.